fix: 🐛 Update login flow to use display and wait for PIN verification#16
Merged
highesttt merged 2 commits intoJan 16, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the LINE bridge login flow to use the LoginProcessDisplayAndWait interface instead of the previous UserInput approach for PIN verification steps. This improves the user experience by providing automatic polling and continuation rather than requiring manual button clicks.
Changes:
- Refactored PIN verification to use
DisplayAndWaitlogin step type with automatic polling - Added
Wait()method implementing theLoginProcessDisplayAndWaitinterface - Extracted common login response handling into a new
handleLoginResponse()method - Updated README with clarification on configuration and additional login methods via Beeper Desktop
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/connector/connector.go | Implements LoginProcessDisplayAndWait interface, adds Wait() and handleLoginResponse() methods, updates PIN verification flow to use display-and-wait pattern |
| README.md | Adds default value for public_address configuration and documents alternative login method via Beeper Desktop Settings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.